Support CertificateManager service #546
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting pull requests, please see the
Development documentation
and specifically the Pull Request Guidelines.
IMPORTANT: Please take note of the below checklist, especially the first three items.
Summary
Relates to #540
Add support for the Certificate Manager service (ACM)
Only the quota "Number of ACM certificates" is checked.
Added unit tests.
Here are the Quotas for the ACM service, as specified in the documentation
(https://docs.aws.amazon.com/acm/latest/userguide/acm-limits.html)
I did not implement the check of limit "Number of ACM certificates per year", because I have no idea how to check it :) This usage "per-year" counts all created certificates, including those that do not exist anymore, hence I assume they will not be listed by the API.
I did not implement the check of limit "Number of imported certificates", because the information of whether a certificate was imported or not is not available in the list_certificates API call, but only in the describe_certificate, and I did not want to make 1 additional call per certificate.
Also, I assumed that imported certificates count toward the total of ACM certificates. But this is not clear from AWS documentation. If I am wrong, awslimitchecker may report a false alert if part of the ACM certificates are imported.
Pull Request Checklist
writing tests for the code, that's fine, just mention that in the summary and either
ask for assistance, or clarify that you'd like someone else to handle the tests. PRs that
include complete test coverage will usually be merged faster.
tox -e docs
connect()
andconnect_resource()
methods, inherited fromawslimitchecker.connectable.Connectable
if you're working on a GitHub issue (i.e. "issue #x - "). Please
refrain from using the "fixes #x" notation unless you are sure that the
the issue is fixed in that commit.
Contributor License Agreement
By submitting this work for inclusion in awslimitchecker, I agree to the following terms:
is being made under the same license as the awslimitchecker project (the Affero GPL v3,
or any subsequent version of that license if adopted by awslimitchecker).
this pull request grants a perpetual, global, unlimited license for it to be used and distributed
under the terms of awslimitchecker's license.