RLSRA: correctly update register dependencies when splitting intervals #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes horrible bug in RSLRA causing arguments not being moved to argument registers when the original interval was split. This was because when updating instructions to use newly create v-reg for just-split interval, register dependencies were not updated, referring to original v-reg. To fix this problem, this commit introduces mew method - `#replaceVirtualRegistersUsing:` - to perform v-reg replacements which updates not only register used by the instruction, but also those referred-to in dependencies (and possibly other Tinyrossa-specific metadata attached to an instruction).
janvrany
force-pushed
the
pr/fix-bug-in-RLSRA-live-interval-splitting
branch
from
794071f to
e3543cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes horrible bug in RSLRA causing arguments not being moved to argument registers when the original interval was split.
This was because when updating instructions to use newly create v-reg for just-split interval, register dependencies were not updated, referring to original v-reg.
To fix this problem, this commit introduces mew method -
#replaceVirtualRegistersUsing:- to perform v-reg replacements which updates not only register used by the instruction, but also those referred-to in dependencies (and possibly other Tinyrossa-specific metadata attached to an instruction).