Misc improvements 12 #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit uses symbols (sub-instances of `TRSymbol`) as labels rather than just plain strings. This is a preparation for using (function) symbols exports.
When building TRIL, one can use `#location:` to set source location for nodes being build. This commit changes to behavior so if `#location:` is used before any node is actually built, it *ALSO* sets location of the whole function. Technically, it sets location of functions entry block's `bbstart` node. This has the nice side-effect of prologue instruction having this location (since prologue instructions are associated with `bbstart` node).
Now when `#getPackageDirectoryForPackage:` is part of pharo-hacks' LibCompat package, `#shellDirectory` can be simplified.
This commit adds `#isBBStart` and `#isBBEnd`. While at it, it changes the way `is<opcode>` methods are implemented. Instead of comparing *opcode's names*, it compares self with the tested opcode itself (using TRILOpcodes pool).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.