Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README out of date #150

Closed
SpaceManiac opened this issue Jun 18, 2017 · 4 comments
Closed

README out of date #150

SpaceManiac opened this issue Jun 18, 2017 · 4 comments

Comments

@SpaceManiac
Copy link

The README currently says:

To build std without the "jemalloc" feature, apply the patch in rust-lang/rust#37975.

This is no longer accurate; the patch is not necessary. Since rust-lang/rust@70d2372, std = { features = ["force_alloc_system"] } is sufficient to disable jemalloc.

@RalfJung
Copy link
Collaborator

The README has been updated by #157.

Notice that, according to rust-lang/rust#43637 (comment), force_alloc_system is not supposed to be used like this. What this flag means is that every program compiled with this libstd can only use the system allocator. If your program tries to set its own allocator, compilation will fail because now two allocators are set (one by libstd, one by your program).

@Others
Copy link

Others commented Aug 21, 2017

I actually think force_alloc_system doesn't even do anything. See this (rust-lang/rust#43637 (comment)) comment:

ah sorry, since jemalloc broke I've said this in a lot of places so I've forgotten who it's been said to. Apart from anything else though, it's actually a no-op right now because it was removed in the global allocator PR - my patch would make it actually do something again.

@RalfJung
Copy link
Collaborator

RalfJung commented Aug 22, 2017

Yes, but that patch they mentioned has landed since then. So right now, it does do something.

@Others
Copy link

Others commented Aug 22, 2017

@RalfJung Yeah, good point. Really the README should just suggest the correct settings in my-custom-target.json. That's the correct way to do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants