Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend std caveats description #157

Merged
merged 2 commits into from
Aug 13, 2017
Merged

extend std caveats description #157

merged 2 commits into from
Aug 13, 2017

Conversation

RalfJung
Copy link
Collaborator

@RalfJung RalfJung commented Aug 8, 2017

I (think I) finally understood why libstd behaves so strangely wrt. dependong on liballoc_jemalloc and libpanic_unwind. This extends the README to explain that.

@alexbool
Copy link

alexbool commented Aug 9, 2017

Great! Maybe you could also revive rust-lang/rust#37975?

@RalfJung
Copy link
Collaborator Author

With the new global allocators system, I am not sure if that's even going to work any more. Currently there is rust-lang/rust#43589 in flight which makes it so that building rustc with jemalloc disabled works at all. Once that lands, maybe we can have a way to control that from the outside when building just libstd. We could use the force_alloc_system flag, but that's explicitly not what it is intended for, and it would fix the allocator to be the system allocator for anything built against this libstd -- so, projects using xargo with a sysroot cold not make use of the global_allocators system. That doesn't seem desirable.

@RalfJung
Copy link
Collaborator Author

Also notice that the changes done by rust-lang/rust#37975 (enabling the alloc_system feature and crate in more cases) are redundant nowadays; the feature and crate are actually unconditionally enabled.

The reference to that PR should be removed from the README, it is no longer useful and the patch no longer applies. One could make an equivalent PR for the new global allocator system, but that would work exactly like setting force_alloc_system: It would make it impossible for users of this libstd to pick their own allocator.

@japaric
Copy link
Owner

japaric commented Aug 13, 2017

Thanks @RalfJung.

@japaric japaric merged commit 33076a9 into japaric:master Aug 13, 2017
@RalfJung RalfJung mentioned this pull request Aug 20, 2017
@RalfJung RalfJung deleted the readme branch August 24, 2019 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants