-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No way to override crates in [patch] section #230
Comments
This was referenced Dec 16, 2018
+1 for letting users specify their own patches. Because I have to patch |
3 tasks
I added support for specifying |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
#228 always adds a
[patch]
section to Xargo'sCargo.toml
s, but there is no way to override the crate it points to. It always uses the crate it find in rust-src, even ifstd
orcore
itself is built using a path or git source. This leads to two different, incompatible, core crates in the dependency tree.See #231 for more issues with git sources.
I've come up with 3 different approaches to fix this, not sure which one is best:
If there is a
std
crate in the blueprint, compute../tools/rustc-std-workspace-core
from that path (or use the same git) and use that as the[patch]
.If there is a
std
crate in the blueprint, find the spec of the core dependency (how would this work ifstd
is a git dependency?), then generate arustc-std-workspace-core
crate in the tempdir with that core. Then, use that temp crate as the[patch]
.Use the existing logic from Fix for latest nightly: need to add a patch section #228 to generate the
[patch]
by default. Let users specify their own[patch]
es inXargo.toml
The text was updated successfully, but these errors were encountered: