Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build for latest Rust nightly source #229

Closed
wants to merge 4 commits into from

Conversation

jethrogb
Copy link
Collaborator

  • add [patch] section for rustc-std-workspace-core crate
  • pull compiler-builtins from crates.io by default

Fixes #227

@@ -77,13 +77,34 @@ version = "0.0.0"

for (_, stage) in blueprint.stages {
let td = TempDir::new("xargo").chain_err(|| "couldn't create a temporary directory")?;
let td = td.path();
let tdp;
let td = if env::var_os("XARGO_KEEP_TEMP").is_some() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol I wish I had had this yesterday^^

@RalfJung
Copy link
Collaborator

Some of this landed with #228, but not all of it.

Also @jethrogb I think you have some use-cases in mind that I didn't know even existed, not sure how they fare now.

Once we resolved this @japaric it would be nice to get a new release.

@jethrogb
Copy link
Collaborator Author

I think the only thing in here that didn't land in some form with #228 is a05e7b5, I'll file a separate PR for that. For the rest, I've filed #230 and #231, the current situation works for my purposes.

@jethrogb jethrogb closed this Dec 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants