Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy bin directory to host sysroot #200

Merged
merged 1 commit into from
Mar 9, 2018
Merged

Conversation

FenrirWolf
Copy link
Contributor

Allows custom targets to use the copy of lld bundled with Rust.

cc rust-lang/rust#48772

@japaric
Copy link
Owner

japaric commented Mar 9, 2018

Thanks @FenrirWolf

bors r+

bors bot added a commit that referenced this pull request Mar 9, 2018
200: Copy bin directory to host sysroot r=japaric a=FenrirWolf

Allows custom targets to use the copy of `lld` bundled with Rust.

cc rust-lang/rust#48772
@bors
Copy link
Contributor

bors bot commented Mar 9, 2018

Build succeeded

@bors bors bot merged commit 9787b69 into japaric:master Mar 9, 2018
@phil-opp
Copy link

phil-opp commented Mar 9, 2018

I just tried it and it seems to work! Thanks a lot @FenrirWolf!

@japaric Could we get a new crates.io release for this?

@FenrirWolf FenrirWolf deleted the copy-bin branch March 9, 2018 16:47
@japaric
Copy link
Owner

japaric commented Mar 9, 2018

@phil-opp v0.3.11 is out and has these changes

@phil-opp
Copy link

phil-opp commented Mar 9, 2018

Thanks a lot!

@ah-
Copy link

ah- commented Mar 10, 2018

Could you please upload binaries for 0.3.11 to https://github.com/japaric/xargo/releases?
In particular xargo-v0.3.11-x86_64-unknown-linux-musl.tar.gz?

I'm using your install.sh script to pull the latest tag and CI is failing as the tag exists, but binaries don't.

Happy to help doing that as well if you point me in the right direction.

@japaric
Copy link
Owner

japaric commented Mar 10, 2018

@ah- done. Linux releases have been uploaded.

@ah-
Copy link

ah- commented Mar 10, 2018

That was quick! Thanks, works perfectly again.

@steveklabnik
Copy link

I had to update my rust nightly as well as install the new xargo to get this to work, but it works for me too!

@Woyten Woyten mentioned this pull request Mar 13, 2018
bors bot added a commit that referenced this pull request Mar 26, 2018
201: Update Cargo.lock r=japaric a=Woyten

Since #200, `Cargo.lock` is considered dirty after Xargo has been built. This is particularly annoying when using Xargo as a Git submodule such as in tock/libtock-rs#18.

This PR updates `Cargo.lock` s.t. it will no longer be considered dirty after building Xargo.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants