Force different metadata for sysroot crates #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for all the extra research! You convinced me that this is a reasonable approach. It would be better to have a test-case, but it seems that is not realistic -- ultimately that means that if this breaks it'll be on you to detect and help fix the problem, but given the low amount of activity here I guess that is not too much of a burden. @jethrogb what do you think? |
RalfJung
reviewed
Dec 3, 2019
I don't have time to look into this in too much detail. I find #261 (comment) convincing and I support making xargo more like the standard compiler build flow in that regard. |
roblabla
force-pushed
the
fix-metadata
branch
from
ef6df7b to
394d272
Compare
|
Thanks! bors r+ |
bors bot
added a commit
that referenced
this pull request
Dec 3, 2019
269: Force different metadata for sysroot crates r=RalfJung a=roblabla If the sysroot and project share a dependency, it might cause conflicts, leading to confusing cargo errors. See https://github.com/roblabla/xargo-reproducer for a reproducer of the issue. This is the same patch as #217 . Fixes #261 I have a way to reproduce the issue this time around (see the issue), but I'm having a hard time figuring out how to properly integrate it within xargo's smoketest. I don't think it's really possible to do in a robust way, actually... Co-authored-by: roblabla <unfiltered@roblab.la>
Build succeeded |
|
Hey, would it be possible to release a new version with this change please? 🙏 |
|
Preparing a new release at #270 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the sysroot and project share a dependency, it might cause conflicts, leading to confusing cargo errors. See https://github.com/roblabla/xargo-reproducer for a reproducer of the issue. This is the same patch as #217 .
Fixes #261
I have a way to reproduce the issue this time around (see the issue), but I'm having a hard time figuring out how to properly integrate it within xargo's smoketest. I don't think it's really possible to do in a robust way, actually...