-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patrickb add rich text #24
Open
patrickbkr
wants to merge
37
commits into
japhb:main
Choose a base branch
from
patrickbkr:patrickb-add-rich-text
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both inherited T-W::Widget which prevented inheriting from them at the same time. Fix this by not having T-W::Input inherit from T-W::Widget anymore. Push the `is` down to the T-W::Input consumers.
Not all widgets that want to be focusable are inputs.
including converting from display indexes back to line indexes.
- Cursor can now jump to the next / previous line. - When cursor pos is beyond the last char (happens when moving between lines), don't require two left keystrokes to move left.
instead of only selecting the line.
This is a preparation for adding the TreeView widget, which will do the same role.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I obviously forgot to open this PR. Even tough the code has been lying around for quite a while now.