Add a connection factory for the async client #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to #146. Using a factory lets users easily handle needed features. This doesn't fully solve #146 at all, but allows for quick workarounds. The default factory accepts random keywords during initialization, that will be given to loop.create_connection. The parameters are different from Factory, but they more or less cover the same features: IPv6 and SSL are now supported out-of-the-box for example. This change shouldn't break any existing code using the library. It can be greatly improved (by improving constistency for example), but it's a start.
|
Closing and re-opening to test against latest code. |
|
This looks great. Thanks! |
jaraco
added a commit
that referenced
this pull request
Mar 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thanks a lot for this library!
This PR adds a factory for the async client, just as it's done for the sync client.
Using a factory lets users easily handle needed features. This doesn't fully solve #146 at all, but allows quick workarounds.
The default factory accepts random keywords during initialization, that will be given to
loop.create_connection. The parameters are different fromFactory, but they more or less cover the same features: IPv6 and SSL are now supported out-of-the-box for example.This change shouldn't break any existing code using the library. It can be greatly improved (by improving consistency for example), but it's a start.