You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
They in fact don't assert that override has the intended effect. And worse, one of them doesn't even perform the correct operation (setting data_path instead of user_data).
Applying the following diff reveals the failure:
diff --git a/jaraco/abode/config.py b/jaraco/abode/config.py
index 423dc55..b8e5148 100644
--- a/jaraco/abode/config.py+++ b/jaraco/abode/config.py@@ -33,6 +33,8 @@ class PlatformDirs(platformdirs.PlatformDirs):
>>> dirs = PlatformDirs(appname='Abode', appauthor=False)
>>> dirs.override(user_data=pathlib.Path('/tmp/foo'))
+ >>> 'foo' in str(dirs.user_data)+ True
"""
for name, path in kwargs.items():
vars(self).update({name + '_path': path})
The text was updated successfully, but these errors were encountered:
As reported in home-assistant/core#123035 (comment), the
PlatformDirs.override
has no effect.I'd swear I tested this behavior, but now that I look at the tests in place:
jaraco.abode/jaraco/abode/config.py
Lines 20 to 22 in 0e4c70d
jaraco.abode/jaraco/abode/config.py
Lines 34 to 35 in 0e4c70d
They in fact don't assert that
override
has the intended effect. And worse, one of them doesn't even perform the correct operation (settingdata_path
instead ofuser_data
).Applying the following diff reveals the failure:
The text was updated successfully, but these errors were encountered: