New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flake8: prefer extend-ignore to ignore #28

Closed

jaraco opened this issue Dec 20, 2020 · 0 comments · Fixed by #33

Owner

jaraco commented Dec 20, 2020

In this comment, webknjaz educates me on the advantages of using extend-ignore instead of ignore, namely saving the need for 503/504 ignores.

This was referenced Dec 20, 2020

Adopt jaraco/skeleton pypa/setuptools#2486

Merged

[CI Regression?] Re-enable flake8 pypa/setuptools#2501

Closed

webknjaz added a commit to webknjaz/jaraco-skeleton that referenced this issue


          Use extend-ignore in flake8 config

8721ca4

This option allows to add extra ignored rules to the default list
instead of replacing it.

The default exclusions are: E121, E123, E126, E226, E24, E704,
W503 and W504.

Fixes jaraco#28.

Refs:
* https://github.com/pypa/setuptools/pull/2486/files#r541943356
* https://flake8.pycqa.org/en/latest/user/options.html#cmdoption-flake8-extend-ignore
*
https://flake8.pycqa.org/en/latest/user/options.html#cmdoption-flake8-ignore

webknjaz mentioned this issue

Use extend-ignore in flake8 config #33

Merged

jaraco closed this as completed in #33

jaraco added a commit that referenced this issue


          Use extend-ignore in flake8 config (#33)

77fbe1d

* Use `extend-ignore` in flake8 config

This option allows to add extra ignored rules to the default list
instead of replacing it.

The default exclusions are: E121, E123, E126, E226, E24, E704,
W503 and W504.

Fixes #28.

Refs:
* https://github.com/pypa/setuptools/pull/2486/files#r541943356
* https://flake8.pycqa.org/en/latest/user/options.html#cmdoption-flake8-extend-ignore
*
https://flake8.pycqa.org/en/latest/user/options.html#cmdoption-flake8-ignore

* Enable complexity limit. Fixes #34.

* Replace pep517.build with build (#37)

* Replace pep517.build with build

Resolves #30

* Prefer simple usage

Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>

* Use license_files instead of license_file in meta (#35)

Singular `license_file` is deprecated since wheel v0.32.0.

Refs:
* https://wheel.readthedocs.io/en/stable/news.html
* https://wheel.readthedocs.io/en/stable/user_guide.html#including-license-files-in-the-generated-wheel-file

Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>

jaraco mentioned this issue

Commits in skeleton close bugs in downstream projects #87

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment