Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable testing merge queues @ GitHub Actions CI/CD #93

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Enable testing merge queues @ GitHub Actions CI/CD #93

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
name: tests

on: [push, pull_request]
on:
merge_group:
push:
branches-ignore:
- gh-readonly-queue/** # Temporary merge queue-related GH-made branches
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is gh-readonly-queue documented? Can we link to the authoritative documentation that recommends this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's where it's documented:

Though, there's no explicit mention of ignoring it. I think, it's because the examples there don't show the simultaneous use of both push and merge_group. This is something that wasn't immediately obvious to me and I got it wrong in a few repos (while it worked in others because they already filtered the branches before the change).

pull_request:

permissions:
contents: read
Expand Down
Loading