Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent fragment from being potentially undefined (Fixes #105) #106

Merged
merged 1 commit into from
Mar 12, 2019

Conversation

coderobe
Copy link
Collaborator

@coderobe coderobe commented Mar 12, 2019

This fixes noise in the center of the circle shader, where d >= (float(C_LINE) / 2.0F) is false.

This fixes #105

…-specific noise

This fixes noise in the center of the circle shader, where `d >= -(float(C_LINE) / 2.0F)` is false
@coderobe coderobe changed the title Prevent fragment from being potentially undefined (Fixes https://github.com/wacossusca34/glava/issues/105) Prevent fragment from being potentially undefined (Fixes #105) Mar 12, 2019
@coderobe coderobe requested a review from jarcode-foss March 12, 2019 15:08
@jarcode-foss
Copy link
Owner

coderobe requested a review from wacossusca34

@@ -32,9 +32,6 @@ out vec4 fragment;
-
-     fragment = vec4(0, 0, 0, 0);
-
@@ -53,6 +50,7 @@ float apply_smooth(float theta) {
+     fragment = vec4(0, 0, 0, 0);

@jarcode-foss jarcode-foss merged commit b37ab5b into master Mar 12, 2019
@coderobe
Copy link
Collaborator Author

Well, last time i merged patches on my own i almost broke compat - remember? :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Undefined behavior in circle shader
2 participants