Skip to content

Conversation

@Enduriel
Copy link

@Enduriel Enduriel commented Sep 3, 2025

This previously made it very difficult to bubble up returned errors

Copilot AI review requested due to automatic review settings September 3, 2025 14:32
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Refactors error return types to use static lifetime instead of borrowing from input parameters, making error propagation easier by removing lifetime dependencies.

  • Changes error return type from &'a str to &'static str in two from_image methods
  • Eliminates the need for error values to be tied to the input parameter's lifetime

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/encoder.rs Updates Encoder::from_image error return type to use static lifetime
src/animation_encoder.rs Updates AnimFrame::from_image error return type to use static lifetime

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant