Update to express 4.0 #145
Conversation
|
express 4.0 has been released: https://github.com/visionmedia/express/releases/tag/4.0.0. +1 on the change. |
|
I just want to add caution to my PR, I am relying only on the unit tests to claim that this works. I have very little experience with Locomotive so before anyone goes using this or merging it I would take a good look for yourself. |
|
+1 |
|
express 4 already released, that's mean you can safely merge it |
| @@ -2,7 +2,7 @@ | |||
| * Module dependencies. | |||
| */ | |||
| var router = require('actionrouter') | |||
| , mime = require('express').mime | |||
| , mime = require('send').mime | |||
There was a problem hiding this comment.
why are you using mime through send module instead of including mime directly?
Require mime directly instead of getting it through send
|
Thanks for finally looking at the changes @just-boris ! I'm a PHP developer, and all I knew is that it "worked" when I made those modifications. I updated the dependencies, and the tests still passing so I assume is all well. |
|
I believe the travis build result is an error with the test runner, testing for Node V10 and v8 both passed. |
Just trying to reduce diff noise
Try to supress diff noise
|
It looks like travis does not support v4 anymore. http://docs.travis-ci.com/user/languages/javascript-with-nodejs/#Provided-Node.js-Versions +1 |
|
Thanks @shawn-crossley ! |
While its not officially out yet, it was actually a pretty quick change to get it working.