fix to allow passwords that contains colons #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any updates on this? Still having to manually encode in my app. |
|
👍 |
FlorianSW
reviewed
Jun 12, 2017
| var userid = credentials[0]; | ||
| var password = credentials[1]; | ||
| var password = credentials.slice(1).join(':'); |
There was a problem hiding this comment.
you should use split() (in L77) with a limit (second parameter), which would avoid the need to workaround the problem in this way.
|
@blevine Are you planning to work on this PR? If not, I would open a new one with your changes and hope that @jaredhanson merges it? :) |
|
@FlorianSW No, I'm not planning to work on this at this time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20