Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the authentication call to check for the OAuth param for errors #63

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

bejoyzm
Copy link

@bejoyzm bejoyzm commented Aug 22, 2016

Added a checking for param error so that appropriate errors are returned to the client.

…rs. If there is error, the code will now throw an InternalOAuthError with the error details.
@coveralls
Copy link

coveralls commented Aug 22, 2016

Coverage Status

Coverage decreased (-1.8%) to 98.23% when pulling 4db350d on bejoyzm:master into 1eb4f22 on jaredhanson:master.

@coveralls
Copy link

coveralls commented Aug 22, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 230bd53 on bejoyzm:master into 1eb4f22 on jaredhanson:master.

@coveralls
Copy link

coveralls commented Aug 23, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 97cb704 on bejoyzm:master into 1eb4f22 on jaredhanson:master.

@rwky
Copy link

rwky commented Jul 7, 2018

@bejoyzm if you make a PR against https://github.com/passport-next/passport-oauth2 is will get looked into.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants