-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OAuth process broken due to Yammer changes #3
Comments
…o be in an Authorization header and not as a query string anymore. Also bumped up the version number to account for the fix.
I'm getting 401 and i'm using passport-yammer2, @oscarrenalias could you help me? |
@mauricionr, it doesn't look like my pull request was merged, and it looks like this module has not been updated for over 2 years by now. You could try using my branch and see if that helps. And it would be useful to know the exact error that you're getting. |
@oscarrenalias, I think i was getting unauthorized because i was'nt a verified admin. |
@oscarrenalias there are other passport modules that have suffered the same fate as this one, i.e. they are outdated with fixes pending. Perhaps you could publish a new module, Either that, or you could start an npm dispute to try and take ownership of the module name: https://docs.npmjs.com/misc/disputes |
@oscarrenalias @jaredhanson - can you offer some guidance on the state of this module and the likelihood of the issues being resolved and PRs being merged? |
Unfortunately, I am no longer using this module and have no plans to continue the development. Maybe someone would like to fork my branch and continue the development there? |
Seems that Yammer recently changed their OAuth 2.0 authentication process to require the OAuth 2.0 token in an Authorization: Bearer token rather than as a query string as it used to be: http://developer.yammer.com/authentication/ (under "Making API requests"). I think it was announced at some point in Yammer's Developer Network but can't find it anymore.
Nevertheless, this means that the current implementation of passport-yammer is broken and it no longer works. It's a tiny fix that I already have in place :), so a pull request is coming in shortly.
The text was updated successfully, but these errors were encountered: