fix: remove conflicting logic from openvpn client disable field #451

jaredhendrickson13 · Apr 11, 2024 · e106e09 · e106e09
1 parent 385ba15
commit e106e09
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/pfSense-pkg-API/files/etc/inc/api/models/APIServicesOpenVPNServerUpdate.inc b/pfSense-pkg-API/files/etc/inc/api/models/APIServicesOpenVPNServerUpdate.inc
@@ -1115,9 +1115,9 @@ class APIServicesOpenVPNServerUpdate extends APIModel {
 
     private function __validate_disabled() {
         # Check for our optional `disabled` payload value
-        if (($this->initial_data["disable"] === true) and (empty($this->validated_data["disable"]))) {
+        if ($this->initial_data["disable"] === true) {
             $this->validated_data["disable"] = "";
-        } elseif (($this->initial_data["disable"] === false) and (!empty($this->validated_data["disable"]))) {
+        } elseif ($this->initial_data["disable"] === false) {
             unset($this->validated_data["disable"]);
         }
     }