Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPSEC VPN Automatic Based on Content option on myid_type and peerid_type #584

Closed
mdepedrof opened this issue Oct 14, 2024 · 5 comments · Fixed by #586
Closed

IPSEC VPN Automatic Based on Content option on myid_type and peerid_type #584

mdepedrof opened this issue Oct 14, 2024 · 5 comments · Fixed by #586
Labels
backlog Issues backlogged for inclusion in future releases enhancement Issues or PRs that enhance existing features

Comments

@mdepedrof
Copy link

mdepedrof commented Oct 14, 2024

In IPSec VPN Phase1 to identify peers in Gui I have the option to specify a String "Automatic Based on Content". Unfortunely i cant find this option in REST API
image

Describe the solution you'd like
Maybe add to de array the opcion "content" to match with te gui opption on myid_type and peerid_type

In gui I have this:
image

@mdepedrof mdepedrof added backlog Issues backlogged for inclusion in future releases feature request New feature or request labels Oct 14, 2024
@mdepedrof
Copy link
Author

mdepedrof commented Oct 18, 2024

While searching in the gui I have seen that the option I am talking about is marked as auto. Could this option be added in the Array of the myid_typeand peerid_type?

Captura de pantalla 2024-10-18 180617

Thanks!!

@mdepedrof
Copy link
Author

Is this posible? Thanks for your work!

@jaredhendrickson13 jaredhendrickson13 added enhancement Issues or PRs that enhance existing features and removed feature request New feature or request labels Oct 21, 2024
@jaredhendrickson13
Copy link
Owner

It's likely all that needs to be done is add auto to the list of choices for that field, if that's the case that can be put in the next patch. I'll have to look at the pfSense codebase to be sure though, sometimes these types of values don't directly relate to its config value and get expanded into different field values.

@jaredhendrickson13
Copy link
Owner

Confirmed that's all that's needed for this. I'll have the changes included in the next patch which should be out this week.

Thanks!

@jaredhendrickson13 jaredhendrickson13 linked a pull request Oct 23, 2024 that will close this issue
@mdepedrof
Copy link
Author

Thanks for your work. Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Issues backlogged for inclusion in future releases enhancement Issues or PRs that enhance existing features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants