Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Firewall floating rule support #188

Merged
merged 8 commits into from
Jan 12, 2022
Merged

Added Firewall floating rule support #188

merged 8 commits into from
Jan 12, 2022

Conversation

pincher95
Copy link
Contributor

Hi Jared,
Followed CONTRIBUTING.md

  • Added support for Firewall floating rule
  • Modified firewall unit test
  • Updated docs

As you requested the merge target changed to v140

@jaredhendrickson13 jaredhendrickson13 merged commit 7bcd618 into jaredhendrickson13:v140 Jan 12, 2022
@jaredhendrickson13 jaredhendrickson13 mentioned this pull request Jan 12, 2022
Merged
@VIKMSTR
Copy link

VIKMSTR commented Mar 17, 2022

Does this cover also selecting multiple interfaces for floating rule or is there any work needed for that?
image

@VIKMSTR VIKMSTR mentioned this pull request Jul 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredhendrickson13 jaredhendrickson13 jaredhendrickson13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pincher95 @VIKMSTR @jaredhendrickson13