#28 [POC] Rewrite After.js as a Razzle 0.9.x plugin #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am open to constructive criticism about do this. In the last 48 hours, I have yet to come up with a build optimization that wouldn't also be useful to Razzle. |
jaredpalmer
changed the title
|
How will this affect the following statement from the README?
|
|
Razzle works really really well with typescript because I use it with typescript every day. 😎 |
|
👍 I was mostly thinking about the "without Babel" part. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This completely rips out all the Razzle internals that (I copy and pasted) from After.js.
Would be upgrade path
after.config.js->razzle.config.jsRelated PR in Razzle jaredpalmer/razzle#457