Create <Field as> and deprecate <Field component> and <Field render> #1406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredpalmer
changed the title
Closed
nathanforce
reviewed
Apr 2, 2019
nathanforce
approved these changes
Apr 2, 2019
hrgui
reviewed
Apr 20, 2019
| ); | ||
|
|
||
| warning( | ||
| component && children && isFunction(children), | ||
| 'You should not use <Field component> and <Field children> as a function in the same <Field> component; <Field component> will be ignored.' | ||
| !!is && !!children && isFunction(children), |
There was a problem hiding this comment.
Since line 94 defaulted https://github.com/jaredpalmer/formik/pull/1406/files#diff-bc78961df770c0df68f6cd758a6f2afdR94 as to input, wouldn't this error message show up every time the dev does this?
<Field name="name">
{({form, field}) => {
return <MyCustomInput {...field} />
}}
</Field>In the example above, as would default to input. In this case, would the check be something like as !== 'input'?
There was a problem hiding this comment.
@jaredpalmer Why we Field render will be deprecated.
Recently, we started using Field render in project. Formik 1.5.8
Please update API examples, if formik going to change ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<Field component>and<Field render>. These haven't been removed. However, they will yield a warning in the console.<Field as>prop which just passes related handlers and props straight through. This should make Styled Components folks happy.Related to #1371
Closes #1407
Closes #1408