-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse Format PR Review Changes #2280
Parse Format PR Review Changes #2280
Conversation
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/jared/formik-docs/q73cgnjr8 |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1b3d5af:
|
Added a small change removing parse and format props from the underlying I was having the double-react issue again. I switched to Yarn, which seemed to help once every few builds, but then I'd get the same error again. Basically, after running yarn link ( |
@johnrom re: lerna, i can commit a tsdx playground that uses parcel to alias the react install |
Fixes items in review for #2255
I didn't actually get a chance to test it on a real project yet. @jaredpalmer do you use npm link?
I think last time I was having issues with "two reacts" when using npm link. Maybe that's been fixed since then.