Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix e2e react usage #3806

Merged
merged 3 commits into from
May 28, 2023
Merged

Fix e2e react usage #3806

merged 3 commits into from
May 28, 2023

Conversation

jaredpalmer
Copy link
Owner

@jaredpalmer jaredpalmer commented May 28, 2023

Since Next.js ships an experimental version of React, linking react in node_modules broke e2e tests due to double react error.

@jaredpalmer jaredpalmer requested a review from quantizor as a code owner May 28, 2023 21:26
@changeset-bot
Copy link

changeset-bot bot commented May 28, 2023

⚠️ No Changeset found

Latest commit: 6ae32dc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented May 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
formik-docs ⬜️ Ignored (Inspect) Visit Preview May 28, 2023 9:30pm

@jaredpalmer jaredpalmer changed the base branch from main to jp/update-actions May 28, 2023 21:26
@codesandbox-ci
Copy link

codesandbox-ci bot commented May 28, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6ae32dc:

Sandbox Source
Formik TypeScript Playground Configuration

@github-actions
Copy link
Contributor

github-actions bot commented May 28, 2023

Size Change: 0 B

Total Size: 40.5 kB

ℹ️ View Unchanged
Filename Size
packages/formik-native/dist/formik-native.cjs.development.js 306 B
packages/formik-native/dist/formik-native.cjs.production.min.js 242 B
packages/formik-native/dist/formik-native.esm.js 238 B
packages/formik-native/dist/index.js 150 B
packages/formik/dist/formik.cjs.development.js 16.2 kB
packages/formik/dist/formik.cjs.production.min.js 7.06 kB
packages/formik/dist/formik.esm.js 16.1 kB
packages/formik/dist/index.js 143 B

compressed-size-action

@jaredpalmer jaredpalmer merged commit 04f8925 into jp/update-actions May 28, 2023
@jaredpalmer jaredpalmer deleted the jp/fix-next-e2e branch May 28, 2023 21:29
jaredpalmer added a commit that referenced this pull request May 28, 2023
* Update GH Actions

* Fix unit test command

* Fix next-link issue

* Fix start:app

* Fix react

* Fix playwright tests w/react event system changes

* Use .blur() in playwright (h/t chatgpt for messing this up)

* Upgrade @testing-library/react

* Switch to .blur()

* Fix e2e react usage (#3806)

* Fix e2e react usage

* Fix lockfile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant