-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing dependency @types/hoist-non-react-statics, closes #3837 #3860
Conversation
🦋 Changeset detectedLatest commit: 6da4ec4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6da4ec4:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
Could you add a changeset please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually sorry, I think this type needs to go in formik's specific package.json not the top one?
Do you mean |
You're seeing that a dependency in a workspace package isn't installing downstream in your client package because it's not present in the workspace root package.json? That seems unlikely. It's currently in |
Indeed, that change resolves the issue. I made the change, and now if I install Formik in another project, the |
This package is needed by Formik but it was not included in the dependency list.
Fixes #3837