Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing dependency @types/hoist-non-react-statics, closes #3837 #3860

Merged
merged 11 commits into from
Sep 17, 2023
Merged

Conversation

patik
Copy link
Contributor

@patik patik commented Aug 6, 2023

This package is needed by Formik but it was not included in the dependency list.

Fixes #3837

@changeset-bot
Copy link

changeset-bot bot commented Aug 6, 2023

🦋 Changeset detected

Latest commit: 6da4ec4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
formik Patch
formik-native Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Aug 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
formik-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 17, 2023 7:45pm

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 6, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6da4ec4:

Sandbox Source
Formik TypeScript Playground (forked) Configuration

quantizor
quantizor previously approved these changes Aug 31, 2023
Copy link
Collaborator

@quantizor quantizor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@quantizor
Copy link
Collaborator

Could you add a changeset please?

quantizor

This comment was marked as outdated.

Copy link
Collaborator

@quantizor quantizor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually sorry, I think this type needs to go in formik's specific package.json not the top one?

@patik
Copy link
Contributor Author

patik commented Sep 10, 2023

Actually sorry, I think this type needs to go in formik's specific package.json not the top one?

Do you mean packages/formik/package.json? This dependency is already listed in that package (it's been there for at least 4 years), but the issue seems to persist unless the dependency is in the root-level package.json.

@quantizor
Copy link
Collaborator

quantizor commented Sep 11, 2023

Actually sorry, I think this type needs to go in formik's specific package.json not the top one?

Do you mean packages/formik/package.json? This dependency is already listed in that package (it's been there for at least 4 years), but the issue seems to persist unless the dependency is in the root-level package.json.

You're seeing that a dependency in a workspace package isn't installing downstream in your client package because it's not present in the workspace root package.json? That seems unlikely.

It's currently in devDependencies, perhaps move it to dependencies in that file?

@patik
Copy link
Contributor Author

patik commented Sep 17, 2023

It's currently in devDependencies, perhaps move it to dependencies in that file?

Indeed, that change resolves the issue. I made the change, and now if I install Formik in another project, the @types/hoist-non-react-statics package is also installed, and the TS error goes away.

package.json Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type error compiling with typescript
2 participants