Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue #3455 #3997

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix issue #3455 #3997

wants to merge 1 commit into from

Conversation

newbie-k
Copy link

@newbie-k newbie-k commented Sep 29, 2024

Copy link

changeset-bot bot commented Sep 29, 2024

🦋 Changeset detected

Latest commit: a29f858

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
formik Major
formik-native Patch
fdocs3 Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Sep 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
formik-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 29, 2024 2:39pm

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@quantizor
Copy link
Collaborator

That link 404s...

@newbie-k
Copy link
Author

@quantizor fixed the link.
Also in packages/formik/test/types.test.tsx there is no test for touched or errors array value.
Maybe that is why this change is pass ?
Might need adding array type value in test file(s) to confirm that this change is working properly.

@quantizor
Copy link
Collaborator

#3455 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants