Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent setState calls in submit if unmounted after validation #861

Merged
merged 2 commits into from
Aug 30, 2018
Merged

Prevent setState calls in submit if unmounted after validation #861

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
46305fd
Prevent setState calls in submit if unmounted after validation
jaredpalmer Aug 30, 2018
4b0ce75
Allow submission even if unmounted
jaredpalmer Aug 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/Formik.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -427,7 +427,8 @@ export class Formik<Values = {}, ExtraProps = {}> extends React.Component<
const isValid = Object.keys(combinedErrors).length === 0;
if (isValid) {
this.executeSubmit();
} else {
} else if (this.didMount) {
// ^^^ Make sure Formik is still mounted before calling setState
this.setState({ isSubmitting: false });
}
});
Expand Down