Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Jest to version 26 #1291

Closed
cereallarceny opened this issue May 6, 2020 · 7 comments
Closed

Upgrade Jest to version 26 #1291

cereallarceny opened this issue May 6, 2020 · 7 comments

Comments

@cereallarceny
Copy link

🚀 Feature request

Current Behavior

Jest 25 utilizes jsdom 15. This has introduced a few errors in my tests that I don't have using Jest 26 outside of Razzle. I'm nearly certain this is an issue related to having an old version of Jest: testing-library/dom-testing-library#477

Desired Behavior

Use Jest 26 throughout the project.

Suggested Solution

Upgrade Jest.

Who does this impact? Who is this for?

All users I suppose.

Additional context

Read this issue: testing-library/dom-testing-library#477

@fivethreeo
Copy link
Collaborator

fivethreeo commented May 10, 2020

Should be doable :) I can do it but if you make a pull request against the next branch that would be great.

@cereallarceny
Copy link
Author

I tried doing this over the weekend, but ran into some pretty huge issues related to package management. Had some issues related to fsevents that I couldn't get cleared up. @fivethreeo would you be able to take this one? Shouldn't take too long, I just wasn't certain on what specific Jest package(s) needed to be upgraded.

@fivethreeo
Copy link
Collaborator

fivethreeo commented May 12, 2020 via email

@cereallarceny
Copy link
Author

Yeah, it caused the test suite to fail.

@fivethreeo
Copy link
Collaborator

Can you try this one out? #1308

@fivethreeo fivethreeo linked a pull request May 20, 2020 that will close this issue
@cereallarceny
Copy link
Author

@fivethreeo I left you a comment on your PR. I couldn't get Jest installed via a branch in my project so I wasn't able to test it... super weird, that's never happened before. However, doing a quick project search I found one extra place where Jest was not bumped to v26: in the main package.json file. After changing that, so long as the test suite runs, I trust this issue should be fixed!

@fivethreeo
Copy link
Collaborator

Fixed in dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants