Add globalSetup, globalTeardown and moduleDirectories as jest options #903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can see snyk is failing, but I don't have the right access level to be able to diagnose why |
jaredpalmer
added a commit
that referenced
this pull request
Apr 16, 2019
* Upgrade Babel to v7, Jest to v23.6 (#775) * Upgrade Babel to v7, Jest to v23.6 Fix the following examples * with-custom-babel-config * with-inferno * with-preact * with-react-native-web * with-rax * Mimic other CRA defaults * Move to Circle 2.0 * Rename folder to .circleci * Change image to 8.12.0 * Change to generic node:8 * Change name of the mdx example * v3.0.0-alpha.0 * Remove polyfills, add treeshaking in production (#788) * Sync with CRA 2 * Remove unused deps * Remove array * Add @babel/runtime as dependency for babel-preset-razzle (#845) * Close #875. Only create one server watcher during development * Bump file-loader to v3 * Remove yarn.lock * Add @babel/core to razzle preset * Upgrade react-loadable example * v3.0.0-alpha.1 * fix: launchEditorEndpoint warning (#877) * v3.0.0-alpha.2 * Bump bs-platform in reason-react example * Bump some deps * Remove dead code * Upgrade to webpack-dev-server 3. Drop speedy fork * [v3] Create razzle-plugin-eslint (#888) * Remove eslint handling from razzle-plugin-typescript * Remove parts from docs mentioning eslint * Move eslint specific code over to razzle-plugin-eslint * Add a temporary eslint-plugin-react setting * Update to the latest eslint packages as defined in react-scripts * Add globalSetup, globalTeardown and moduleDirectories as jest options (#903) * add globalSetup, globalTeardown and moduleDirectories to jest allowed * rerun tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change liberates three additional options that are imho crucial for testing server side development:
.babelrc=>module-resolvermodule-resolverallows you toabsoluteimport components that are not innode_modules, e.g.import TextInput from 'components/form/TextInput, wherecomponentsis placed insrc/components. It helps keep your code more readable and not have endless../../../componentsstyle imports.When you use this, jest also needs to know, and
moduleDirectoriesis the key for it.I didn't quite understand why these keys were blocked, but perhaps this is a relic of
create-react-appthat for obvious reasons doesn't bear the burden of server side testing.