Skip to content

Commit

Permalink
(fix): @types/jest should be a dep, not a devDep (#672)
Browse files Browse the repository at this point in the history
- per bug report, this caused an issue where the @types/jest that was
  installed via `create` would have a version mismatch with the jest
  and jest-related deps used by TSDX
- and ts-jest's installation instructions also say to install
  @types/jest, so it's kind of a peerDep to it

- also move @types/shelljs to devDeps as it's not needed for usage of
  the CLI, it's only used internally
  • Loading branch information
agilgur5 authored Apr 11, 2020
1 parent 351936e commit 2930943
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
"@rollup/plugin-json": "^4.0.0",
"@rollup/plugin-node-resolve": "^7.1.0",
"@rollup/plugin-replace": "^2.2.1",
"@types/shelljs": "^0.8.5",
"@types/jest": "^24.0.15",
"@typescript-eslint/eslint-plugin": "^2.12.0",
"@typescript-eslint/parser": "^2.12.0",
"ansi-escapes": "^4.2.1",
Expand Down Expand Up @@ -102,7 +102,6 @@
"@types/eslint": "^6.1.2",
"@types/execa": "^0.9.0",
"@types/fs-extra": "^8.0.0",
"@types/jest": "^24.0.15",
"@types/ms": "^0.7.30",
"@types/node": "^13.1.0",
"@types/ora": "^3.2.0",
Expand All @@ -111,6 +110,7 @@
"@types/rollup-plugin-sourcemaps": "^0.4.2",
"@types/sade": "^1.6.0",
"@types/semver": "^7.1.0",
"@types/shelljs": "^0.8.5",
"@types/styled-components": "^5.0.1",
"autoprefixer": "^9.7.4",
"babel-plugin-replace-identifiers": "^0.1.1",
Expand Down
2 changes: 1 addition & 1 deletion src/templates/basic.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { Template } from './template';

const basicTemplate: Template = {
name: 'basic',
dependencies: ['@types/jest', 'husky', 'tsdx', 'tslib', 'typescript'],
dependencies: ['husky', 'tsdx', 'tslib', 'typescript'],
packageJson: {
// name: safeName,
version: '0.1.0',
Expand Down

0 comments on commit 2930943

Please sign in to comment.