Skip to content

Commit

Permalink
(remove): redundant/confusing tsconfig target in templates (#466)
Browse files Browse the repository at this point in the history
- tsconfig target is always overwritten to ESNext by TSDX, and then
  the rest of the transpilation is done by @babel/preset-env
  - having templates with target set gives the false impression that
    target can be freely configured

- also remove from tests as it's unused there
  • Loading branch information
agilgur5 authored Jan 29, 2020
1 parent 95ff6da commit 670cc56
Show file tree
Hide file tree
Showing 6 changed files with 1 addition and 7 deletions.
1 change: 0 additions & 1 deletion templates/basic/tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
{
"include": ["src", "types", "test"],
"compilerOptions": {
"target": "es5",
"module": "esnext",
"lib": ["dom", "esnext"],
"importHelpers": true,
Expand Down
1 change: 0 additions & 1 deletion templates/react-with-storybook/tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
{
"include": ["src", "types", "test"],
"compilerOptions": {
"target": "es5",
"module": "esnext",
"lib": ["dom", "esnext"],
"importHelpers": true,
Expand Down
1 change: 0 additions & 1 deletion templates/react/tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
{
"include": ["src", "types", "test"],
"compilerOptions": {
"target": "es5",
"module": "esnext",
"lib": ["dom", "esnext"],
"importHelpers": true,
Expand Down
1 change: 0 additions & 1 deletion test/fixtures/build-default/tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
{
"compilerOptions": {
"target": "es5",
"module": "ESNext",
"lib": ["dom", "esnext"],
"declaration": true,
Expand Down
1 change: 0 additions & 1 deletion test/fixtures/build-invalid/tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
{
"compilerOptions": {
"target": "es5",
"module": "ESNext",
"lib": ["dom", "esnext"],
"declaration": true,
Expand Down
3 changes: 1 addition & 2 deletions test/fixtures/build-withConfig/tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
{
"compilerOptions": {
"target": "es5",
"module": "ESNext",
"lib": ["dom", "esnext"],
"declaration": true,
Expand All @@ -26,4 +25,4 @@
"esModuleInterop": true
},
"include": ["src", "types"],
}
}

0 comments on commit 670cc56

Please sign in to comment.