feat: add noEmit to templates' tsconfigs

- for ease of use when using `tsc` for type-checking, which a lot of users already do - it doesn't fully type-check everything though, since we'd need to split off a tsconfig.build.json in order to let builds only run on `src` while type-checking would run on all files - but people already using `tsc --noEmit`, so might as well start supporting this as it's not uncommon - also add to all fixtures - yea some centralization/extends or dogfooding create would help reduce all this duplication
jaredpalmer · Sep 17, 2020 · c802b8b · c802b8b
1 parent e0f79fe
commit c802b8b
Show file tree

Hide file tree

Showing 9 changed files with 15 additions and 6 deletions.
diff --git a/templates/basic/tsconfig.json b/templates/basic/tsconfig.json
@@ -17,5 +17,6 @@
     "esModuleInterop": true,
     "skipLibCheck": true,
     "forceConsistentCasingInFileNames": true,
+    "noEmit": true,
   }
 }
diff --git a/templates/react-with-storybook/tsconfig.json b/templates/react-with-storybook/tsconfig.json
@@ -17,5 +17,6 @@
     "esModuleInterop": true,
     "skipLibCheck": true,
     "forceConsistentCasingInFileNames": true,
+    "noEmit": true,
   }
 }
diff --git a/templates/react/tsconfig.json b/templates/react/tsconfig.json
@@ -17,5 +17,6 @@
     "esModuleInterop": true,
     "skipLibCheck": true,
     "forceConsistentCasingInFileNames": true,
+    "noEmit": true,
   }
 }
diff --git a/test/e2e/fixtures/build-default/tsconfig.json b/test/e2e/fixtures/build-default/tsconfig.json
@@ -14,7 +14,8 @@
     "jsx": "react",
     "esModuleInterop": true,
     "skipLibCheck": true,
-    "forceConsistentCasingInFileNames": true
+    "forceConsistentCasingInFileNames": true,
+    "noEmit": true
   },
   "include": ["src", "types"]
 }
diff --git a/test/e2e/fixtures/build-invalid/tsconfig.json b/test/e2e/fixtures/build-invalid/tsconfig.json
@@ -14,7 +14,8 @@
     "jsx": "react",
     "esModuleInterop": true,
     "skipLibCheck": true,
-    "forceConsistentCasingInFileNames": true
+    "forceConsistentCasingInFileNames": true,
+    "noEmit": true
   },
   "include": ["src", "types"]
 }
diff --git a/test/e2e/fixtures/build-withTsconfig/tsconfig.base.json b/test/e2e/fixtures/build-withTsconfig/tsconfig.base.json
@@ -16,7 +16,8 @@
     "jsx": "react",
     "esModuleInterop": false,
     "skipLibCheck": true,
-    "forceConsistentCasingInFileNames": true
+    "forceConsistentCasingInFileNames": true,
+    "noEmit": true
   },
   "include": ["src", "types"], // test parsing of trailing comma & comment
 }
diff --git a/test/integration/fixtures/build-options/tsconfig.json b/test/integration/fixtures/build-options/tsconfig.json
@@ -14,7 +14,8 @@
     "jsx": "react",
     "esModuleInterop": true,
     "skipLibCheck": true,
-    "forceConsistentCasingInFileNames": true
+    "forceConsistentCasingInFileNames": true,
+    "noEmit": true
   },
   "include": ["src", "types"],
 }
diff --git a/test/integration/fixtures/build-withBabel/tsconfig.json b/test/integration/fixtures/build-withBabel/tsconfig.json
@@ -14,7 +14,8 @@
     "jsx": "react",
     "esModuleInterop": true,
     "skipLibCheck": true,
-    "forceConsistentCasingInFileNames": true
+    "forceConsistentCasingInFileNames": true,
+    "noEmit": false
   },
   "include": ["src", "types"],
 }
diff --git a/test/integration/fixtures/build-withConfig/tsconfig.json b/test/integration/fixtures/build-withConfig/tsconfig.json
@@ -14,7 +14,8 @@
     "jsx": "react",
     "esModuleInterop": true,
     "skipLibCheck": true,
-    "forceConsistentCasingInFileNames": true
+    "forceConsistentCasingInFileNames": true,
+    "noEmit": true
   },
   "include": ["src", "types"],
 }