Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typecheck only once for all formats? #757

Closed
Semesse opened this issue Jul 12, 2020 · 0 comments · Fixed by #758
Closed

Typecheck only once for all formats? #757

Semesse opened this issue Jul 12, 2020 · 0 comments · Fixed by #758
Labels
kind: optimization Performance, space, size, etc improvement

Comments

@Semesse
Copy link
Contributor

Semesse commented Jul 12, 2020

Current Behavior

It seems that if --transpileOnly is not enabled, type checking will be applied to every format
https://github.com/formik/tsdx/blob/b91ab47e3a04e11f356f252240666b8d17c0afd8/src/createRollupConfig.ts#L179

Desired Behavior

Check types only once.

Suggested Solution

Disable type check for latter builds. I've seen a great boost for default configs, and I'd like to create a PR for this.

Who does this impact? Who is this for?

All typescript users will benefit from this since type check might be the bottleneck for most build processes.

Describe alternatives you've considered

Additional context

@agilgur5 agilgur5 changed the title Isn't it great to check type once for all formats? Typecheck only once for all formats? Jul 12, 2020
@agilgur5 agilgur5 added the kind: optimization Performance, space, size, etc improvement label Jul 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: optimization Performance, space, size, etc improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants