Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optim: only check types once #758

Merged
merged 1 commit into from
Jul 19, 2020
Merged

optim: only check types once #758

merged 1 commit into from
Jul 19, 2020

Conversation

Semesse
Copy link
Contributor

@Semesse Semesse commented Jul 12, 2020 •
edited by agilgur5
Loading

Fixes #757

Change-Id: I998648be8181371ec14e23a3096dc3b4ac731957

optim: only check types once
3e8e376 
Change-Id: I998648be8181371ec14e23a3096dc3b4ac731957
@agilgur5 agilgur5 added the kind: optimization Performance, space, size, etc improvement label Jul 12, 2020
agilgur5
agilgur5 approved these changes Jul 12, 2020
View reviewed changes
Copy link
Collaborator

@agilgur5 agilgur5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I must've missed this in #691.

This should be an even greater speed boost than the type declaration one. Would want to test this out a bit to get a rough idea what the % improvement is like I did for #691

@agilgur5
Copy link
Collaborator

The CI runs can vary highly and some came out slower than previous CI, but in other places there was a 10-20s improvement, which is big. I'll have to run it over a few times locally to get a more accurate estimate since CI runners aren't quite as stable.

@agilgur5
Copy link
Collaborator

It's roughly another 10-15% perf boost, so together with #691 it's a 20-30% perf boost! YMMV of course though

@agilgur5 agilgur5 merged commit 79dddc4 into jaredpalmer:master Jul 19, 2020
@agilgur5
Copy link
Collaborator

@allcontributors please add @Semperia for code

@allcontributors allcontributors bot mentioned this pull request Jul 19, 2020
Merged
@allcontributors
Copy link
Contributor

@agilgur5

I've put up a pull request to add @Semperia! 🎉

@agilgur5 agilgur5 mentioned this pull request Oct 7, 2020
Merged
paul-vd pushed a commit to EezyQuote/tsdx that referenced this pull request Dec 1, 2020
@Semesse @paul-vd
optim: only check types once (jaredpalmer#758)
2e4ee54 
- each format has the same input, so type-checking only needs to
  occur once total
  - previously it was once per format

Change-Id: I998648be8181371ec14e23a3096dc3b4ac731957

Co-authored-by: Lai Hongjie <laihongjie@bytedance.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agilgur5 agilgur5 agilgur5 approved these changes

Assignees
No one assigned
Labels
kind: optimization Performance, space, size, etc improvement
Projects
None yet
Milestone
v0.13.x - Template Improvements & More
Development

Successfully merging this pull request may close these issues.

Typecheck only once for all formats?
2 participants
@Semesse @agilgur5