Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doctype to react template html file #164

Merged
merged 1 commit into from
Jul 5, 2019
Merged

Add doctype to react template html file #164

merged 1 commit into from
Jul 5, 2019

Conversation

leonardodino
Copy link
Contributor

@leonardodino leonardodino commented Jul 4, 2019

Hey there 👋 Thanks for this awesome package!


Pretty minor diff, but react-live was having weird rendering issues without it.

Only discovered because I was porting an already functioning example, without any code changes.

I can also run prettier on this file if preferred.
vscode ends up auto-formatting it on save.

@swyxio swyxio merged commit 8455d28 into jaredpalmer:master Jul 5, 2019
@leonardodino leonardodino deleted the react-doctype branch July 5, 2019 13:49
@agilgur5
Copy link
Collaborator

@allcontributors please add @leonardodino for code, bug

@allcontributors
Copy link
Contributor

@agilgur5

I've put up a pull request to add @leonardodino! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants