Use @wessberg/rollup-plugin-ts + change output naming structure
#219
Conversation
Signed-off-by: Charlike Mike Reagent <opensource@tunnckocore.com>
Signed-off-by: Charlike Mike Reagent <opensource@tunnckocore.com>
tunnckoCore
changed the title
@wessberg/rollup-plugin-ts@wessberg/rollup-plugin-ts + change output naming structure
Signed-off-by: Charlike Mike Reagent <opensource@tunnckocore.com>
Signed-off-by: Charlike Mike Reagent <opensource@tunnckocore.com>
|
Why are we changing the output format? |
| `${paths.appDist}/${safePackageName(opts.name)}`, | ||
| opts.format, | ||
| opts.env, | ||
| `${paths.appDist}/${opts.format}/index`, |
There was a problem hiding this comment.
If we were nice we would automagically update folks package.json for them
There was a problem hiding this comment.
Meaning? Codemod thingy? It's could be the next possible step after this whole change.
|
|
||
| expect(shell.test('-f', 'dist/index.d.ts')).toBeTruthy(); | ||
| expect(shell.test('-f', 'dist/cjs/index.js')).toBeTruthy(); | ||
| expect(shell.test('-f', 'dist/cjs/index.min.js')).toBeTruthy(); |
There was a problem hiding this comment.
I am confused. Is .min the production version?
There was a problem hiding this comment.
Sure. Why otherwise one will want minifying? and especially, in cjs/node target.
For "reasons", the other PR has comments around that :) Or at least because such design decisions, problems and "features" appear in some other places/tools (referring the new "hook" option in the |
agilgur5
added
topic: rollup-plugin-typescript2
Addresses #208 and #200.
tsdx createaccording to new output structure; Plus, correct "package generation". Currently, if user type@hela/corein the prompt it will createcorefolder in thecwdand also will add to the generated package.json file a name field to becoreinstead@hela/core, which definitely isn't correct behavior.use stricton thetsdx-build.test.js, obviously according to the given eslint config and prettier.pnpm ion fresh branch, the pnpm's lockfile changed.The only left is to update the
babelPluginTsdxfile, meaning to drop therollup-plugin-babeldependency and just generate babel config and pass it asbabelConfigoption to the ts plugin. But keep in mind the ts plugin also automatically includes some plugins and does merging some default options.