fix(lint): do not output warning about react on non-react projects #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthurdenner
changed the title
swyxio
approved these changes
Nov 6, 2019
|
looks good enough. ready to merge? |
|
@sw-yx, I believe so. 😃 |
|
thanks for the great pr! will go out with the next release |
|
Would you consider shipping a tiny patch release with this change? Or have some bigger changes already made it into master that make that tricky? Not a big deal either way, of course - just curious. Thanks! |
|
its up to @jaredpalmer - he controls the releases |
|
When to push this change to npm？i think i need it. @jaredpalmer |
|
thanks for the great PR! @all-contributors please add @arthurdenner for bugs, code |
|
I've put up a pull request to add @arthurdenner! 🎉 |
|
Do you know if this change has been released yet? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current behavior:
We get a warning about detecting React version using the
lintcommand in non-react projects.New behavior:
Using the shared settings and the same value used by
eslint-plugin-reactinternally - it could be almost any value - we don't get the warning on non-react projects. Closes #279.How to reproduce:
tsdx lintinside a react and a non-react project;Notes:
N/A.