Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Gluegun #32

Closed
wants to merge 4 commits into from
Closed

WIP Gluegun #32

wants to merge 4 commits into from

Conversation

jaredpalmer
Copy link
Owner

@jaredpalmer jaredpalmer commented Jan 31, 2019

Closes #17

This starts to refactor the project to use gluegun instead of sade. So far I don't see a massive gain aside from testing with gluegun. However, if we get into template stuff then it will seems worth it.

I also figured out how to improve logging (#1). Anyways, this is a GIF of the logger in this branch.

kapture 2019-01-31 at 18 02 10

@birkir
Copy link
Collaborator

birkir commented Feb 1, 2019

Looking good Jared.

I'm not helping in any way by saying this, but have you tried Ink#next? It has Yoga now, which is pretty darn impressive! Maybe something to keep an eye for when tsdx starts to have more configurability (if thats even something you actually want)

https://github.com/vadimdemedes/ink/tree/next

https://twitter.com/vadimdemedes/status/1089344289102942211

@swyxio
Copy link
Collaborator

swyxio commented Feb 1, 2019

would love to get started on a React template once this is merged. actually holding off on #5 bc of this

@jaredpalmer
Copy link
Owner Author

So it looks like none of the rollup plugins have TS types which sucks. Gluegun so far is decent for testing, and maybe templating, but it doesn't do much for argument parsing at all. In fact, much less than sade or oclif. The TS types for Gluegun are also fairly weak in my opinion. 🤷 oclif also does automatic documentation generation which is pretty sweet. I may try that as well.

@birkir I will peek at ink this weekend. I think a progress bar could be useful here and some info about gzip/brotli/minified sizing. I already prettified the error logging and made it compatible with VS Code Problems list, but more could be done I think.

@jaredpalmer jaredpalmer changed the title Gluegun WIP Gluegun Feb 1, 2019
@jaredpalmer jaredpalmer closed this Feb 2, 2019
@swyxio swyxio deleted the gluegun branch August 26, 2019 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants