Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(package): update @types/jest to version 25.1.0 #462

Merged
merged 1 commit into from
Jan 28, 2020

Conversation

greenkeeper[bot]
Copy link
Contributor

@greenkeeper greenkeeper bot commented Jan 27, 2020

The devDependency @types/jest was updated from 24.9.1 to 25.1.0.

This version is not covered by your current version range.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.


Publisher: types
License: MIT

Find out more about this release.


FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper bot 🌴

@swyxio swyxio changed the title Update @types/jest to the latest version 🚀 chore(package): update @types/jest to version 25.1.0 Jan 28, 2020
@swyxio swyxio merged commit 95ff6da into master Jan 28, 2020
@agilgur5
Copy link
Collaborator

agilgur5 commented Jan 29, 2020

A few questions/concerns:

  • TSDX still uses Jest v24 -- why were the types updated?
  • Jest v24.3+ has types built-in, is @types/jest still necessary?
  • The package.json was updated, but not the yarn.lock file -- can PR a fix to this but not sure I should based on the above

EDIT: I think the lockfile is the result of the error in https://github.com/jaredpalmer/tsdx/pull/466/checks?check_run_id=414995509

@swyxio
Copy link
Collaborator

swyxio commented Jan 29, 2020

hmm.. my bad. didnt think it through.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
greenkeeper topic: Jest 25 Related to Jest 25 upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants