(feat): support JS & JSX files in tsdx lint #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- JS & JSX are already supported in tsdx build, so this is just adding
some better parity in tsdx test
- more JS & JSX support also means better support for gradual TS
migrations
- prior to this, JS & JSX files wouldn't be linted unless explicitly
included with a glob or something
- extensions is also only configurable via CLIEngine, .eslintrc
doesn't currently support it
- fix errors & warnings in JS test files as TSDX dogfoods its own lint
functionality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JS & JSX are already supported in tsdx build, so this is just adding
some better parity in tsdx test
migrations
prior to this, JS & JSX files wouldn't be linted unless explicitly
included with a glob or something
doesn't currently support it
fix errors & warnings in JS test files as TSDX dogfoods its own lint
functionality
I'm currently adding TSDX in https://github.com/agilgur5/react-signature-canvas while migrating it to TS and this came up as frustration. Related to #486
EDIT: For posterity, here's my PR agilgur5/react-signature-canvas#42, and specifically agilgur5/react-signature-canvas@2980b8a is where this popped up -- note the custom
package.jsonlintscript.