fix: anchor regexps in Jest transforms for proper JSON handling #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyle-johnson
commented
Feb 18, 2020
| @@ -4,8 +4,8 @@ export function createJestConfig( | |||
| ) { | |||
| const config = { | |||
| transform: { | |||
| '.(ts|tsx)': require.resolve('ts-jest/dist'), | |||
| '.(js|jsx)': require.resolve('babel-jest'), // jest's default | |||
| '.(ts|tsx)$': require.resolve('ts-jest/dist'), | |||
There was a problem hiding this comment.
Added the $ here just to be consistent!
|
This may interact with #491 |
|
Which should I merge? |
|
@all-contributors please add @kyle-johnson for bug, code |
|
I've put up a pull request to add @kyle-johnson! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Master has a new regexp for Jest which breaks tests that reference JSON at some point in the dependency chain. This is a fix.
The regexp
.(js|jsx)matches.jsonwhich means Jest attempts to load JSON files as JS modules. Since they aren't modules, Jest fails.