(fix): correctly read tsconfig esModuleInterop #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- it's a property of compilerOptions, not of overall tsconfig
- i.e. tsconfig.compilerOptions.esModuleInterop
- because this was incorrectly read, Rollup's esModule would always
be set to `undefined`, and Rollup would then default to `true`
- so esModuleInterop still wasn't being respected properly, I just
shifted the defaults when I incorrectly patched this :/
(test): add tests for the default tsconfig as well as for when it's
explicitly set to false
agilgur5
force-pushed
the
fix-esmodule-undefined
branch
from
deeb4fe to
3bdaca7
Compare
|
Ok, so the test failures are very weird, because it even got Like No one has complained about it being wrong since #367, nay, I even tested and use this in my own libraries... And I just manually confirmed the output is correct again in the default and This might just be an artifact with how Jest loads these things 😕 🤷♂ |
agilgur5
commented
Mar 11, 2020
paul-vd
pushed a commit
to EezyQuote/tsdx
that referenced
this pull request
Dec 1, 2020
- it's a property of compilerOptions, not of overall tsconfig
- i.e. tsconfig.compilerOptions.esModuleInterop
- because this was incorrectly read, Rollup's esModule would always
be set to `undefined`, and Rollup would then default to `true`
- so esModuleInterop still wasn't being respected properly, I just
shifted the defaults when I incorrectly patched this :/
(test): add tests for the default tsconfig as well as for when it's
explicitly set to false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it's a property of compilerOptions, not of overall tsconfig
because this was incorrectly read, Rollup's esModule would always
be set to
undefined, and Rollup would then default totrueshifted the defaults when I incorrectly patched this :/
(test): add tests for the default tsconfig as well as for when it's
explicitly set to false
Fixes #469 . Actually this was unintentionally fixed by me a short while ago when I updated #489 , but this improves the syntax and adds tests
This is a follow-up on bugs in #327