Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(test): ensure custom --tsconfig path is correctly read #556

Merged
merged 1 commit into from
Mar 11, 2020

Conversation

agilgur5
Copy link
Collaborator

  • this never had tests for it, so ensure it's properly read
    • make sure extends works, that an override works, and that paths
      are correctly resolved

Basically ensure that #436 works

- this never had tests for it, so ensure it's properly read
  - make sure extends works, that an override works, and that paths
    are correctly resolved
@agilgur5 agilgur5 force-pushed the test-custom-tsconfig-path branch from 9a5a4fb to aa7f103 Compare March 11, 2020 00:31
Copy link
Collaborator Author

@agilgur5 agilgur5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pretty small PR

@agilgur5 agilgur5 merged commit 3530265 into jaredpalmer:master Mar 11, 2020
paul-vd pushed a commit to EezyQuote/tsdx that referenced this pull request Dec 1, 2020
)

- this never had tests for it, so ensure it's properly read
  - make sure extends works, that an override works, and that paths
    are correctly resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant