(ci): remove experimental --runInBand as tests pass now #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- this was added as an attempt to fix persistent CI errors that were
occurring due to the now deprecated `moveTypes()` function
- now that those have been fixed, this is no longer needed and should
have a small speed bump by removing this
- though it's possible --runInBand fixed a different CI error that
happened less frequently: `EPERM` on creating directories on
Windows, not sure, will find out
paul-vd
pushed a commit
to EezyQuote/tsdx
that referenced
this pull request
Dec 1, 2020
) - this was added as an attempt to fix persistent CI errors that were occurring due to the now deprecated `moveTypes()` function - now that those have been fixed, this is no longer needed and should have a small speed bump by removing this - though it's possible --runInBand fixed a different CI error that happened less frequently: `EPERM` on creating directories on Windows, not sure, will find out
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
occurring due to the now deprecated
moveTypes()functionhave a small speed bump by removing this
happened less frequently:
EPERMon creating directories onWindows, not sure, will find out
Basically a revert of #429 since #504 fixed the root cause behind most of the CI issues. If the Windows
EPERMerrors start happening again, we can revert this revert and then we'll know the--runInBandflag actually fixes it and that it's some type of race condition or something.This was split out from #621 where CI passed a couple times with these changes