(refactor): migrate all tests and test helper code to TS #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- woot, all TS now!
- get that big blue line for language TS on GitHub haha
- for the most part, not much more to do other than .js -> .ts
- for the utils had to add some types around
- also use ESM instead of CJS in tests and test helpers
- require -> import
- module.exports -> export
- the indentation change here with utils/fixture made git treat
it as a delete + new instead of a rename
agilgur5
commented
Mar 28, 2020
|
|
paul-vd
pushed a commit
to EezyQuote/tsdx
that referenced
this pull request
Dec 1, 2020
…#649) - woot, all TS now! - get that big blue line for language TS on GitHub haha - for the most part, not much more to do other than .js -> .ts - for the utils had to add some types around - also use ESM instead of CJS in tests and test helpers - require -> import - module.exports -> export - the indentation change here with utils/fixture made git treat it as a delete + new instead of a rename
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
woot, all TS now!
for the most part, not much more to do other than .js -> .ts
also use ESM instead of CJS in tests and test helpers
it as a delete + new instead of a rename
This was, of course, done because #627 added lots of tests, and definitely not because TSDX became majority JavaScript after #627. This was definitely not because the majority JavaScript made TSDX classified as a "JavaScript" library
(it actually wasn't, I always wanted to convert the tests to TS, especially after the addition of the
grephelper with JSDoc types in #525 (later moved to #627 which got merged first). but I can't say that didn't increase priority 😉 ).