Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update @typescript-eslint/parser to the latest version 🚀 #728

Closed

Conversation

greenkeeper[bot]
Copy link
Contributor

@greenkeeper greenkeeper bot commented May 21, 2020


🚨 Reminder! Less than one month left to migrate your repositories over to Snyk before Greenkeeper says goodbye on June 3rd! 💜 🚚💨 💚

Find out how to migrate to Snyk at greenkeeper.io


The dependency @typescript-eslint/parser was updated from 2.34.0 to 3.0.0.

This version is not covered by your current version range.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.


Publisher: jameshenry
License: BSD-2-Clause

Release Notes for v3.0.0

This major release has been a long time coming! We've been saving up breaking changes for a while now, waiting for the ESLint v7 release which we knew would deprecate support for node version 8.

Due to our weekly release cadence, this major release mostly contains breaking changes!

Breaking Changes

Dropped support for Node version 8 (#1420)

In line with ESLint v7 - we've also dropped explicit support for node version 8.
This version of node has been end of life since 2019-12-31.
We no longer test against the version, so we provide no guarantees about whether or not future versions of our tooling will work on it.

Dropped support for TypeScript 3.2 (#2004)

Old TS versions cause us maintenance pain as we work on integrating tightly with the TypeScript APIs for performance and stability reasons.

As such we've updated our required TS version range to require a minimum of >=3.3.1.

Each version of TS brings bugfixes and features, but most importantly they bring performance improvements. TS 3.9 is releasing with a host of performance improvements that will improve both your build times, and your lint times - so you should endeavour to upgrade if you can. We cannot provide any guarantees around the performance of old TS versions.

Configs

We've updated all of our configs! We've added new rules, old rules, and removed some stylistic rules.

Both of the recommended and recommended-requiring-typechecking sets now inherit from the eslint-recommended set. We noticed that the majority of the time, users were using the sets in tandem, so this just removes one line of config for everyone.

Check out the linked issues for more information about added/removed rules:

  • eslint-recommended config (#1273)
  • recommended config (#1423)
  • recommended-requiring-typechecking (#1423)

Rules Changes

  • ban-types got a rework of its default ban list to provide some more sensible defaults and remove fixers that caused users issues. (#848)
  • no-floating-promises now has the ignoreVoid option set to true by default. (#2003)
  • no-unnecessary-condition
    • the ignoreRHS option has been removed. The rule will now only check the RHS when it matters (i.e. in boolean contexts). (#1163)
    • the checkArrayPredicates option has been removed. The rule will now always check array predicate functions. (#1579)
    • the rule now will report if you do an equality check against null/undefined when the value is not nullable. (#1659)
  • prefer-nullish-coalescing
    • the fixer has been converted to a suggestion fixer always - it was unsafe in most cases.
    • removed option forceSuggestionFixer.
  • prefer-optional-chain
    • the fixer has been converted to a suggestion fixer always - it was unsafe in a number of cases.
    • removed option suggestInsteadOfAutofix.
  • restrict-template-expressions
    • now has the allowNumber option set to true by default. (#2005)
    • allowNullable has been renamed to allowNullish. (#2006)
  • strict-boolean-expression received a complete rework. The rule is now more configurable, with smarter defaults and more intuitive logic. (#1515)

Rule Removals

The following deprecated rules have been deleted. Please switch to the listed alternative:

AST Changes

  • typescript-estree now emits a TSEmptyBodyFunctionExpression when it encounters a function expression without a body. Previously this was done in parser (for legacy reasons). This change should only affect users directly consuming typescript-estree. (#1289)
  • When a method is marked as optional (class Foo { name?() {} }) we now mark the MethodDefinition/TSAbstractMethodDefinition as optional. Previously we marked the key of the node as optional, but this only works if the key is an Identifier, and didn't work in the case of a computed key (class Foo { ['name']?() {} }). (#1429)
  • Import expressions (import('foo')) now conform to the newly released ESTree spec, outputting as an ImportExpression. (#1950)
  • BigInt literals now conform to the newly released ESTree spec, outputting as a Literal with a value of type bigint. (#1999)

Parser Services

parserServices are now always emitted from both typescript-estree and parser, regardless of the parserOptions.project configuration. (#716)

This will allow you to consume parts of the TypeScript API that are generated at the file level, like variable usage diagnostics, without requiring full type information is generated for the project.

Part of this change includes a new boolean flag on the output: parserServices.hasFullTypeInformation which is true when parserOptions.project was configured, and false otherwise.

If you were using our getParserServices function from experimental-utils, then this will be handled automatically, and you will not notice any changes. If you built your own function for resolving the parserServices, then you'll have to update accordingly.

ESLint Types (experimental-utils)

The old version of our ESLint types were based on those found in the DefinitelyTyped repo. There was a lot of missing documentation, missing properties, misnamed types.

As part of this release, we've reworked some of the internals to be much closer to the ESLint library itself. (#2023)

As part of this change, we have also added the types for the new ESLint class.
SourceCode.isSpaceBetween has also been marked as optional, because it is only available in ESLint v6+

Non-breaking changes

ESLint v7

We now have full support for ESLint v7 (#1550).

Better handling for TS 3.9's non-null assertion changes (#2036)

TS 3.9 introduced a breaking change for how non-null assertions are handled in optional chains.

Pre-3.9, x?.y!.z means (x?.y).z - i.e. it essentially scrubbed the optionality from the chain
Post-3.9, x?.y!.z means x?.y!.z - i.e. it just asserts that the property y is non-null, not the result of x?.y

Previously x?.y!.z produced MemberExpression > TSNonNullAssertion > OptionalMemberExpression.
Now it produces OptionalMemberExpression > TSNonNullAssertion > OptionalMemberExpression.

Note that both (x?.y)!.z and (x?.y!).z still produce MemberExpression > TSNonNullAssertion > OptionalMemberExpression.
The same applies for call expressions.

The rule no-non-null-asserted-optional-chain was also updated to handle this appropriately. It will no longer error on x?.y!.z, but it will still error on (x?.y)!.z.

Bug Fixes

  • eslint-plugin: [dot-notation] fix typo in schema (#2040) (242328f)
Commits

The new version differs by 34 commits.

  • 1765a17 chore: remove v3 canary Ci step
  • 7e39f5b v3.0.0
  • 3dfc46d feat: add index files to parser and typescript-estree
  • 52b6085 feat(eslint-plugin): [prefer-nullish-coalescing][prefer-optional-chain] remove unsafe fixers
  • ae82ea4 fix(experimental-utils): add back SourceCode.isSpaceBetweenTokens
  • fe59f69 fix(eslint-plugin): correct parser peerDep version
  • f199cbd fix(typescript-estree): remove now defunct Import node type
  • a35026d chore: provide more granularity in the CI logs (#2024)
  • 06869c9 feat(experimental-utils): upgrade eslint types for v7 (#2023)
  • 208de71 feat: upgrade to ESLint v7 (#2022)
  • 7ad4d7c feat: bump minimum required TS version (#2004)
  • 264b017 feat(eslint-plugin): [restrict-template-expressions] rename allowNullable to allowNullish (#2006)
  • bfd9b60 feat(eslint-plugin): [no-unnecessary-condition] remove checkArrayPredicates and always check it (#1579)
  • 7fa9060 feat(eslint-plugin): [no-unnecessary-condition] report when non-nullish is compared to null/undefined (#1659)
  • 643ec24 feat(eslint-plugin): [restrict-template-expressions] allowNumber: true by default (#2005)

There are 34 commits in total.

See the full diff


FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper bot 🌴

@greenkeeper

This comment has been minimized.

greenkeeper bot added a commit that referenced this pull request May 25, 2020
@greenkeeper

This comment has been minimized.

greenkeeper bot added a commit that referenced this pull request May 27, 2020
@greenkeeper

This comment has been minimized.

greenkeeper bot added a commit that referenced this pull request Jun 1, 2020
@agilgur5
Copy link
Collaborator

Per the release notes this is Node 10+. Also TS 3.2+ but that doesn't affect us, well past that version. Other than that seems to be a not too large set of rule changes that are breaking. eslint-config-prettier, which provides prettier/@typescript-eslint, doesn't seem to list any specific changes for this upgrade in its CHANGELOG 🤔

This should be done simultaneously with #729 . Ideally batched with all the other linting updates, e.g. Prettier v2 #632

@agilgur5
Copy link
Collaborator

agilgur5 commented Oct 2, 2020

Found out in #890 (comment) that this is actually a dep only because it's a peerDep of eslint-config-react-app, CRA's shareable config that we use. We don't directly use this dep and eslint-config-react-app has not yet updated per that comment, but will update to v4 (this updates to v3) in a future breaking change

@agilgur5
Copy link
Collaborator

Since this is a peer, it needs to be updated simultaneously with eslint-config-react-app, which has not produced a major bump to upgrade this plugin yet. Closing as this plugin should not be upgraded independently and Dependabot policy has been set to prevent this now.

Repository owner locked as resolved and limited conversation to collaborators Oct 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant