Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: capitalize 'S' in TypeScript #752

Merged
merged 1 commit into from
Sep 17, 2020
Merged

docs: capitalize 'S' in TypeScript #752

merged 1 commit into from
Sep 17, 2020

Conversation

orta
Copy link
Contributor

@orta orta commented Jul 7, 2020

No description provided.

@agilgur5 agilgur5 changed the title minor readme change Capitalize 'S' in TypeScript Jul 7, 2020
@agilgur5
Copy link
Collaborator

agilgur5 commented Jul 7, 2020

There's a few other places it's not capitalized if one wants to be consistent: https://github.com/formik/tsdx/search?p=2&q=TypeScript&unscoped_q=TypeScript

@agilgur5 agilgur5 added the scope: docs Documentation could be improved. Or changes that only affect docs label Aug 19, 2020
@agilgur5 agilgur5 mentioned this pull request Sep 17, 2020
Merged
@agilgur5 agilgur5 added the problem: stale Issue has not been responded to in some time label Sep 17, 2020
@agilgur5 @orta
docs: capitalize 'S' in TypeScript
217cff3 
- also capitalize 'S' in JavaScript for consistency

- reword a confusing comment in the codebase that mentioned
  "typescript types" (and hence showed up on regex search) to
  more accurate "type declarations" phrasing
  - this seems to have been added in the early days of TSDX,
    in commit 6bbf077

Co-Authored-By: Orta Therox <orta.therox+github@gmail.com>
@agilgur5 agilgur5 changed the title Capitalize 'S' in TypeScript docs: capitalize 'S' in TypeScript Sep 17, 2020
@vercel
Copy link

vercel bot commented Sep 17, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/formium/tsdx/1l09fldch
✅ Preview: https://tsdx-git-fork-orta-patch-1.formium.vercel.app

@agilgur5
Copy link
Collaborator

Updated this myself to include all references to "TypeScript", as I mentioned above, as well as the one "JavaScript" one:

Description

docs: capitalize 'S' in TypeScript

  • also capitalize 'S' in JavaScript for consistency

  • reword a confusing comment in the codebase that mentioned
    "typescript types" (and hence showed up on regex search) to
    more accurate "type declarations" phrasing

    • this seems to have been added in the early days of TSDX,
      in commit 6bbf077

agilgur5
agilgur5 approved these changes Sep 17, 2020
View reviewed changes
Copy link
Collaborator

@agilgur5 agilgur5 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few one-char changes and one two word change

@agilgur5 agilgur5 merged commit da4b189 into jaredpalmer:master Sep 17, 2020
paul-vd pushed a commit to EezyQuote/tsdx that referenced this pull request Dec 1, 2020
@orta @agilgur5 @paul-vd
docs: capitalize 'S' in TypeScript (jaredpalmer#752)
62ac30e 
- also capitalize 'S' in JavaScript for consistency

- reword a confusing comment in the codebase that mentioned
  "typescript types" (and hence showed up on regex search) to
  more accurate "type declarations" phrasing
  - this seems to have been added in the early days of TSDX,
    in commit 6bbf077

Co-Authored-By: Orta Therox <orta.therox+github@gmail.com>

Co-authored-by: Anton Gilgur <agilgur5@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agilgur5 agilgur5 agilgur5 approved these changes

Assignees
No one assigned
Labels
problem: stale Issue has not been responded to in some time scope: docs Documentation could be improved. Or changes that only affect docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@orta @agilgur5